[PATCH] D146266: gn build: Fix Android build.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/lib/Support/BUILD.gn:7
     "//llvm/lib/Demangle",
+    "//llvm/utils/gn/build/libs/implicit",
     "//llvm/utils/gn/build/libs/pthread",
----------------
pcc wrote:
> aeubanks wrote:
> > why put this in Support rather than something like `executable` (which you had mentioned trying)?
> Unfortunately that wouldn't work, because the deps attribute is not allowed on config.
> 
> https://gn.googlesource.com/gn/+/main/docs/reference.md#func_config
I just remembered how this is done in Chromium, they define template wrappers around the target types that invoke the linker: https://source.chromium.org/chromium/chromium/src/+/main:build/config/BUILDCONFIG.gn;l=512

That's a much better approach, so I'll switch to that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146266/new/

https://reviews.llvm.org/D146266