[PATCH] D146257: Consume "size_text" instead of size..text or size.__text

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: lnt/tests/test_suite.py:716
             'link_time': 'compile',
-            'size..text': 'code_size',
             'mem_bytes': 'mem',
----------------
azharudd wrote:
> Wouldn't it be a more clear/straightforward solution to just add another line here for `'size.__text'` (similar to what we are doing for `mem` right below)?
> 
> ```
> 'size..text': 'code_size',
> # On Darwin, the section name is reported as `__text`.
> 'size.__text': 'code_size',
> ```
> 
> Only one of `'size..text'` or `'size.__text'` would exist in the lit output, and whichever exists would correspond to the `'code_size'`.  This way, we would also not need https://reviews.llvm.org/D146260, and the lit output will continue to have the  exact section name. 
Sure, that sounds good to me.


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146257/new/

https://reviews.llvm.org/D146257