[PATCH] D146405: [mlir][Bazel] Avoid attribute((weak)) for MSVC.

Mon Mar 20 01:46:16 PDT 2023

csigg added a comment.

It seems this would result in duplicate definitions of `mlir::registerGpuSerializeToCubinPass()` on Windows.

Maybe we could use /alternatename <https://devblogs.microsoft.com/oldnewthing/20200731-00/?p=104024>? 
I'm not sure how to handle mangled names though.

Alternatively, the above article also links to this approach <https://devblogs.microsoft.com/oldnewthing/20130109-00/?p=5613>, but getting bazel (and CMake) to link in a specific way might be tricky.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146405/new/

https://reviews.llvm.org/D146405

[PATCH] D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC.

[PATCH] D146405: [mlir][Bazel] Avoid attribute((weak)) for MSVC.