[PATCH] D146405: [mlir][Bazel] Avoid __attribute__((weak)) for MSVC.

[Adrian Kuegel via Phabricator via llvm-commits]

akuegel created this revision.
akuegel added a reviewer: csigg.
Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, thopre.
Herald added a project: All.
akuegel requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, nicolasvasilache.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146405

Files:
  utils/bazel/llvm-project-overlay/mlir/BUILD.bazel


Index: utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
===================================================================
--- utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -4088,22 +4088,26 @@
     ] + if_cuda_available([
         "@cuda//:cuda_headers",
         "@cuda//:libcuda",
-    ])
+    ]),
 )
 
 write_file(
     name = "SerializeToCubin_stub_cc",
     out = "SerializeToCubin_stub.cc",
     content = [
-"""
+        """
 #include "mlir/Dialect/GPU/Transforms/Passes.h"
 
 // Provide a weak registration stub in case the real SerializeToCubin is not
 // linked in.
 
+#if defined(_MSC_VER)
+void mlir::registerGpuSerializeToCubinPass() {}
+#else
 __attribute__((weak)) void mlir::registerGpuSerializeToCubinPass() {}
-"""
-    ]
+#endif
+""",
+    ],
 )
 
 cc_library(
@@ -7113,8 +7117,8 @@
         ":OpenMPDialect",
         ":Pass",
         ":QuantOps",
-        ":SerializeToCubin",
         ":SCFToGPU",
+        ":SerializeToCubin",
         ":Support",
         ":Transforms",
         "//llvm:AllTargetsCodeGens",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146405.506480.patch
Type: text/x-patch
Size: 1098 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230320/027025a8/attachment.bin>