[PATCH] D136774: [Outliner] Add an option to only enable outlining of patterns above a certain threshold

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 18:19:20 PDT 2023


paquette added a comment.

> The overhead of representing a new function in the binary depends on exception metadata and alignment

Is it possible to know this without introducing a heuristic?



================
Comment at: llvm/lib/CodeGen/MachineOutliner.cpp:121
+    "outliner-benefit-threshold", cl::init(1), cl::Hidden,
+    cl::desc("The minimum size before an outlining candidate is accpeted"));
+
----------------



================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-threshold.ll:1
+; RUN: llc -verify-machineinstrs -enable-machine-outliner -aarch64-load-store-renaming=true -mtriple=aarch64-apple-darwin -outliner-benefit-threshold=60 < %s | FileCheck %s
+; RUN: llc -verify-machineinstrs -enable-machine-outliner -aarch64-load-store-renaming=true -mtriple=aarch64-apple-darwin < %s | FileCheck %s -check-prefix=ALL
----------------
MIR testcase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136774/new/

https://reviews.llvm.org/D136774



More information about the llvm-commits mailing list