[PATCH] D136774: [Outliner] Add an option to only enable outlining of patterns above a certain threshold

[Kyungwoo Lee via Phabricator via llvm-commits]

kyulee added a comment.

Overall it looks good to me. Just simplify the test case that is more resilient to the future changes.



================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-threshold.ll:6
+  ; CHECK-LABEL: _cat:
+  ; CHECK: sub sp, sp, #32
+  ; ALL: [[OUTLINED:OUTLINED_FUNCTION_[0-9]+]]
----------------
```
; CHECK-NOT: OUTLINED_FUNCTION
```


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-threshold.ll:25
+  ; CHECK-LABEL: _dog:
+  ; CHECK: sub sp, sp, #32
+  ; ALL: [[OUTLINED]]
----------------
```
; CHECK-NOT: OUTLINED_FUNCTION
```


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-threshold.ll:92
+
+;      CHECK: .p2align 2
+; CHECK-NEXT: [[OUTLINED]]:
----------------
I would simplify all the following without matching align and the body of outlined function which can vary.
```
; CHECK: [[OUTLINED]]:
; ALL-DAG: [[OUTLINED]]:
; ALL-DAG: [[OUTLINED2]]:
```


================
Comment at: llvm/test/CodeGen/AArch64/machine-outliner-threshold.ll:117
+
+attributes #0 = { nounwind noredzone "target-cpu"="cyclone" "target-features"="+sse" }
----------------
Is this necessary?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136774/new/

https://reviews.llvm.org/D136774