[PATCH] D146324: scudo: Don't define mallinfo2 on Android.

Fri Mar 17 14:59:14 PDT 2023

pcc added a comment.

In D146324#4203326 <https://reviews.llvm.org/D146324#4203326>, @Chia-hungDuan wrote:

> In D146324#4203093 <https://reviews.llvm.org/D146324#4203093>, @pcc wrote:
>
>> How do you usually build Scudo? When I run the unit tests I cross compile it for Android using llvm's gn build system. If you're building it as part of the Android platform, `SCUDO_PREFIX` will be defined to add a prefix of `scudo_`, so the alias in `malloc.h` wouldn't affect the definitions.
>
> I see, thanks!
>
> That prefix is only added when  `#if SCUDO_ANDROID && _BIONIC` (code <https://llvm.googlesource.com/scudo/+/0f7da7e39e8bef784e77ad6848554dc16d63e2fb/wrappers_c_bionic.cpp#22>), do you think we need to do `#if !SCUDO_ANDROID || !_BIONIC`?

That shouldn't be necessary, we aren't using `scudo_mallinfo2` on the platform side.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146324/new/

https://reviews.llvm.org/D146324