[PATCH] D146276: [GuardWidening] Improve analysis of potential widening into hotter block

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GuardWidening.cpp:481
+      return IfTrue;
+    // TODO: Use branch frequency metatada to allow hoisting through non-guard
+    // branches?
----------------
skatkov wrote:
> Don't you want to also check that we are ok if some of the successors ends up with deoptimization?
> 
> IfTrue/ifFalse ->getPostdominatingDeoptimizeCall() ?
It's expensive. What is the advantage of this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146276/new/

https://reviews.llvm.org/D146276