[PATCH] D146276: [GuardWidening] Improve analysis of potential widening into hotter block

Serguei Katkov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 02:28:45 PDT 2023


skatkov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GuardWidening.cpp:481
+      return IfTrue;
+    // TODO: Use branch frequency metatada to allow hoisting through non-guard
+    // branches?
----------------
Don't you want to also check that we are ok if some of the successors ends up with deoptimization?

IfTrue/ifFalse ->getPostdominatingDeoptimizeCall() ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146276/new/

https://reviews.llvm.org/D146276



More information about the llvm-commits mailing list