[PATCH] D146206: [LAA] Fix transitive analysis invalidation bug by implementing LoopAccessInfoManager::invalidate

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added inline comments.


================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/invalidation.ll:4
+
+; RUN: opt < %s -disable-output -debug-pass-manager -passes='function(require<access-info>,invalidate<aa>),print<access-info>,function(invalidate<access-info>)' 2>&1 | FileCheck %s --check-prefix=CHECK-AA
+;
----------------
nikic wrote:
> What is the extra invalidate at the end of the pipeline for?
That was to see what happened when having an explicit invalidation of access-info. I.e. that the new invalidate function returns true in the early "// If not, give up now." exit, so that my patch wasn't lacking the check previously made by the default invalidate function.

Maybe nicer to extract that kind of test into a separate RUN-line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146206/new/

https://reviews.llvm.org/D146206