[PATCH] D146206: [LAA] Fix transitive analysis invalidation bug by implementing LoopAccessInfoManager::invalidate

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 02:55:24 PDT 2023


nikic added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2719-2726
+  if (Inv.invalidate<AAManager>(F, PA) ||
+      Inv.invalidate<ScalarEvolutionAnalysis>(F, PA) ||
+      Inv.invalidate<LoopAnalysis>(F, PA) ||
+      Inv.invalidate<DominatorTreeAnalysis>(F, PA))
+    return true;
+
+  // Otherwise this analysis result remains valid.
----------------



================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/invalidation.ll:4
+
+; RUN: opt < %s -disable-output -debug-pass-manager -passes='function(require<access-info>,invalidate<aa>),print<access-info>,function(invalidate<access-info>)' 2>&1 | FileCheck %s --check-prefix=CHECK-AA
+;
----------------
What is the extra invalidate at the end of the pipeline for?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146206/new/

https://reviews.llvm.org/D146206



More information about the llvm-commits mailing list