[PATCH] D144356: [XCOFF] support the ref directive for object generation.

[Esme Yi via Phabricator via llvm-commits]

Esme added inline comments.


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:89
+  const MCSymbolRefExpr *SRE = MCSymbolRefExpr::create(Symbol, getContext());
+  MCFixup Fixup = MCFixup::create(DF->getContents().size(), SRE, FK_NONE);
+  DF->getFixups().push_back(Fixup);
----------------
shchenz wrote:
> Do you think reusing PPC fixup kind `fixup_ppc_nofixup` for AIX `R_REF` type relocation makes more sense?
The `fixup_ppc_nofixup` is defined in `llvm/lib/Target/PowerPC/MCTargetDesc/PPCFixupKinds.h`, and it looks inappropriate to include that in `llvm/lib/MC`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144356/new/

https://reviews.llvm.org/D144356