[PATCH] D144356: [XCOFF] support the ref directive for object generation.

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:89
+  const MCSymbolRefExpr *SRE = MCSymbolRefExpr::create(Symbol, getContext());
+  MCFixup Fixup = MCFixup::create(DF->getContents().size(), SRE, FK_NONE);
+  DF->getFixups().push_back(Fixup);
----------------
Do you think reusing PPC fixup kind `fixup_ppc_nofixup` for AIX `R_REF` type relocation makes more sense?


================
Comment at: llvm/test/CodeGen/PowerPC/pgo-ref-directive.ll:9
+; RUN:     -xcoff-traceback-table=false --filetype=obj < %t/with-vnds.ll -o %t/with-vnds.o
+; RUN: llvm-objdump %t/with-vnds.o -tr | FileCheck %s --check-prefix=OBJ
 
----------------
Can we add RUN lines for another two cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144356/new/

https://reviews.llvm.org/D144356