[PATCH] D146142: InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:890-891
     // Equivalent of == 0.
-    Value *FCmp =
-        Builder.CreateFCmpOEQ(Src0, ConstantFP::get(Src0->getType(), 0.0));
-
+    Value *FCmp = IsUnordered ? Builder.CreateFCmpUEQ(Src0, Zero)
+                              : Builder.CreateFCmpOEQ(Src0, Zero);
     FCmp->takeName(&II);
----------------
There might be a bug here if the test mask only included snan or qnan individually 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146142/new/

https://reviews.llvm.org/D146142