[PATCH] D146142: InstCombine: Fold is.fpclass nan|zero to fcmp ueq 0

Wed Mar 15 08:42:58 PDT 2023

arsenm added a comment.

In D146142#4196643 <https://reviews.llvm.org/D146142#4196643>, @kpn wrote:

> Where is fpclassTestIsFCmp0 implemented?

In 4109e3f1db4e0024c87f01cf20dd19ad85779e37 <https://reviews.llvm.org/rG4109e3f1db4e0024c87f01cf20dd19ad85779e37>

================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:886
+
   if (!IsStrict &&
+      fpclassTestIsFCmp0(OrderedMask, *II.getFunction(), Src0->getType())) {
----------------
kpn wrote:
> Any chance we can be consistent with formatting? The check for !IsStrict was formatted consistently before. Pedantic, perhaps, but it jumped out at me.
This is what clang-format did 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146142/new/

https://reviews.llvm.org/D146142