[PATCH] D146129: [Target][RISCV] Fix inconsistent naming of Predicates (NFCI).
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 15 04:58:30 PDT 2023
asb added a comment.
Thanks for making this suggestion.
The suggested renaming would be consistent with those other predicates, but RV{32,64}{I,E} are different base ISAs while the other predicates refer to instruction set extensions. Because of this logical distinction IsRV32/IsRV64 make more sense to me at least.
It's a bit less clear for RVE given the way me model it within LLVM is somewhat like as if it was an instruction set extension. Though I still think I personally prefer `IsRVE` for that case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146129/new/
https://reviews.llvm.org/D146129
More information about the llvm-commits
mailing list