[PATCH] D146129: [Target][RISCV] Fix inconsistent naming of Predicates (NFCI).

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 04:48:00 PDT 2023


fpetrogalli created this revision.
fpetrogalli added a reviewer: craig.topper.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson.
Herald added a project: All.
fpetrogalli requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

def FeatureWhatever

      : SubtargetFeature<"...", "HasPredicateWhatever", "...", "...">;
                                    ^^^^^
  		  Name and Subtarget invocation of the Predicate
  		  defined next:

def HasPredicateWhatever : Predicate<"Subtarget->hasPredicateWhatever()"> ...;

This is consistent with the other SubtargetFeature and Predicate pairs
defined in RISCVTargetFeatures.td.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D146129

Files:
  llvm/lib/Target/RISCV/RISCVFeatures.td
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/lib/Target/RISCV/RISCVInstrInfo.td
  llvm/lib/Target/RISCV/RISCVInstrInfoA.td
  llvm/lib/Target/RISCV/RISCVInstrInfoC.td
  llvm/lib/Target/RISCV/RISCVInstrInfoD.td
  llvm/lib/Target/RISCV/RISCVInstrInfoF.td
  llvm/lib/Target/RISCV/RISCVInstrInfoM.td
  llvm/lib/Target/RISCV/RISCVInstrInfoV.td
  llvm/lib/Target/RISCV/RISCVInstrInfoXVentana.td
  llvm/lib/Target/RISCV/RISCVInstrInfoZb.td
  llvm/lib/Target/RISCV/RISCVInstrInfoZc.td
  llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td
  llvm/lib/Target/RISCV/RISCVInstrInfoZk.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D146129.505443.patch
Type: text/x-patch
Size: 53951 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230315/d7ceca5f/attachment-0001.bin>


More information about the llvm-commits mailing list