[PATCH] D125807: [ConstantFolding] Pre-commit tests showing denormal handling during folding

David Candler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 15 03:20:46 PDT 2023


dcandler added a comment.

In D125807#4195745 <https://reviews.llvm.org/D125807#4195745>, @simonwallis2 wrote:

> I'm not sure what is the right protocol for adding review comments to a long-submitted patch.
> But, whilst thinking of adding float16 tests, I noticed 4 possible inconsistencies in float32 tests.

Yes, I remember spotting this as well. It seems I did include corrections for them in https://reviews.llvm.org/D129298 but that was ultimately abandoned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125807/new/

https://reviews.llvm.org/D125807



More information about the llvm-commits mailing list