[PATCH] D125807: [ConstantFolding] Pre-commit tests showing denormal handling during folding

[Simon Wallis via Phabricator via llvm-commits]

simonwallis2 added a comment.
Herald added a subscriber: StephenFan.

I'm not sure what is the right protocol for adding review comments to a long-submitted patch.
But, whilst thinking of adding float16 tests, I noticed 4 possible inconsistencies in float32 tests.



================
Comment at: llvm/test/Transforms/InstSimplify/constant-fold-fp-denormal.ll:561
+
+define float @test_float_fneg_pzero_out() #0 {
+; CHECK-LABEL: @test_float_fneg_pzero_out(
----------------
Should #0 be #1? otherwise this test is identical to the previous test, including having the same attributes


================
Comment at: llvm/test/Transforms/InstSimplify/constant-fold-fp-denormal.ll:568
+
+define float @test_float_fneg_psign_out() #0 {
+; CHECK-LABEL: @test_float_fneg_psign_out(
----------------



================
Comment at: llvm/test/Transforms/InstSimplify/constant-fold-fp-denormal.ll:575
+
+define float @test_float_fneg_pzero_in() #0 {
+; CHECK-LABEL: @test_float_fneg_pzero_in(
----------------



================
Comment at: llvm/test/Transforms/InstSimplify/constant-fold-fp-denormal.ll:582
+
+define float @test_float_fneg_psign_in() #0 {
+; CHECK-LABEL: @test_float_fneg_psign_in(
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D125807/new/

https://reviews.llvm.org/D125807