[PATCH] D145929: [LSR] Fold terminating condition not only for eq and ne

[Nikita Popov via Phabricator via llvm-commits]

nikic requested changes to this revision.
nikic added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: StephenFan.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6729
+    }
+  }
 
----------------
Drop this code, it doesn't make any sense.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6947
+                              ? CmpInst::ICMP_EQ
+                              : CmpInst::ICMP_NE;
+      Value *NewTermCond =
----------------
This is very likely incorrect -- the predicate is decided by which of the branch targets is loop exiting. Please add test variants where the predicate and the branch targets are inverted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145929/new/

https://reviews.llvm.org/D145929