[PATCH] D145929: [LSR] Fold terminating condition not only for eq and ne

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 13:42:52 PDT 2023


reames added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp:6936
       IRBuilder<> LatchBuilder(LoopLatch->getTerminator());
-      // FIXME: We are adding a use of an IV here without account for poison safety.
-      // This is incorrect.
----------------
This change *does not* address this FIXME.  Please restore the comment.

No comment on the review otherwise.  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145929/new/

https://reviews.llvm.org/D145929



More information about the llvm-commits mailing list