[PATCH] D145893: [X86][MC]Fix wrong action for encode movdir64b

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:395
+    if (getMemBaseReg() &&
+        (!X86MCRegisterClasses[X86::GR32RegClassID].contains(getMemBaseReg()) &&
+         !(getMemBaseReg() == X86::EIP)))
----------------
Why do you need parentheses around `!X86MCRegisterClasses[X86::GR32RegClassID].contains(getMemBaseReg()`?


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:396
+        (!X86MCRegisterClasses[X86::GR32RegClassID].contains(getMemBaseReg()) &&
+         !(getMemBaseReg() == X86::EIP)))
+      return false;
----------------
Why not `!=`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145893/new/

https://reviews.llvm.org/D145893