[PATCH] D145893: [X86][MC]Fix wrong action for encode movdir64b

[Wang, Xin via Phabricator via llvm-commits]

XinWang10 marked 3 inline comments as done.
XinWang10 added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86Operand.h:398
+    if (getMemIndexReg() &&
+        !X86MCRegisterClasses[X86::GR32RegClassID].contains(getMemIndexReg()))
+      return false;
----------------
craig.topper wrote:
> XinWang10 wrote:
> > craig.topper wrote:
> > > Do you need to include X86::EIZ?
> > I search it and it is used in decoding? seems EIZ can not be used in encode, I try it with gas 'movdir64b  291(%esi, %eiz, 4), %ebx', and report 'Error: bad register name `%eiz''
> gas requires `.allow_index_reg` directive to enable riz/eiz parsing.
> gas requires `.allow_index_reg` directive to enable riz/eiz parsing.

It worked. Will do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145893/new/

https://reviews.llvm.org/D145893