[PATCH] D146050: [RISCV]Combine (select(seteq (and X, 1 << C), 0) to select_cc

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 14 08:37:15 PDT 2023

Previous message: [PATCH] D146050: [RISCV]Combine (select(seteq (and X, 1 << C), 0) to select_cc
Next message: [PATCH] D146050: [RISCV]Combine (select(seteq (and X, 1 << C), 0) to select_cc
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

craig.topper added a comment.

The test cases here only test the most significant bit, but your patch checks any power of 2. Can you add more test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146050/new/

https://reviews.llvm.org/D146050

Previous message: [PATCH] D146050: [RISCV]Combine (select(seteq (and X, 1 << C), 0) to select_cc
Next message: [PATCH] D146050: [RISCV]Combine (select(seteq (and X, 1 << C), 0) to select_cc
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list