[PATCH] D145353: [PowerPC] remove side effect for some cases for saturate instructions

Mon Mar 13 18:21:32 PDT 2023

shchenz marked an inline comment as done.
shchenz added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/vector-sum-sat-bit-side-effect.ll:12
 ; CHECK:       # %bb.0: # %entry
-; CHECK-NEXT:    xxlxor v3, v3, v3
-; CHECK-NEXT:    vsum4sbs v2, v2, v3
 ; CHECK-NEXT:    blr
 entry:
----------------
nemanjai wrote:
> I think it would be more useful to add a use of the actual sum in at least one of the tests. The test would have one call that is used and one that is unused. Previous to this patch, we would emit both and with this patch, we only emit the one that is used.
Sure, I will add 3 new cases in the commit. And these cases will contains two calls, one call has user and one call has no user, so this call can be optimized by this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145353/new/

https://reviews.llvm.org/D145353