[PATCH] D145353: [PowerPC] remove side effect for some cases for saturate instructions

Mon Mar 13 05:22:14 PDT 2023

nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM. I don't think that the test improvement requires another review.

================
Comment at: llvm/test/CodeGen/PowerPC/vector-sum-sat-bit-side-effect.ll:12
 ; CHECK:       # %bb.0: # %entry
-; CHECK-NEXT:    xxlxor v3, v3, v3
-; CHECK-NEXT:    vsum4sbs v2, v2, v3
 ; CHECK-NEXT:    blr
 entry:
----------------
I think it would be more useful to add a use of the actual sum in at least one of the tests. The test would have one call that is used and one that is unused. Previous to this patch, we would emit both and with this patch, we only emit the one that is used.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145353/new/

https://reviews.llvm.org/D145353