[PATCH] D110978: [SLP]Improve gathering of the scalars used in the graph.
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Mar 13 14:42:25 PDT 2023
ABataev added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6726
+ return Pair.value() == UndefMaskElem ||
+ Pair.index() == static_cast<unsigned>(Pair.value());
+ }));
----------------
RKSimon wrote:
> Any chance that we can use ShuffleVectorInst::isIdentityMask ?
Sure, will do it later
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7175
+ ScalarTy = SI->getValueOperand()->getType();
+ else if (CmpInst *CI = dyn_cast<CmpInst>(VL[0]))
+ ScalarTy = CI->getOperand(0)->getType();
----------------
RKSimon wrote:
> auto *
Both these cases are the existing code, just the diff is not quite correct because of the big differences.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110978/new/
https://reviews.llvm.org/D110978
More information about the llvm-commits
mailing list