[PATCH] D110978: [SLP]Improve gathering of the scalars used in the graph.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:6726
+                return Pair.value() == UndefMaskElem ||
+                       Pair.index() == static_cast<unsigned>(Pair.value());
+              }));
----------------
Any chance that we can use ShuffleVectorInst::isIdentityMask ? 


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7173
+  Type *ScalarTy = VL[0]->getType();
+  if (StoreInst *SI = dyn_cast<StoreInst>(VL[0]))
+    ScalarTy = SI->getValueOperand()->getType();
----------------
auto *


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7175
+    ScalarTy = SI->getValueOperand()->getType();
+  else if (CmpInst *CI = dyn_cast<CmpInst>(VL[0]))
+    ScalarTy = CI->getOperand(0)->getType();
----------------
auto *


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110978/new/

https://reviews.llvm.org/D110978