[PATCH] D145895: [ADT] Implement {DenseMap,MapVector,StringMap}::contains

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 08:04:20 PDT 2023


kuhar accepted this revision.
kuhar added a comment.
This revision is now accepted and ready to land.

LGTM.

Separately, it would be cool if we could make `llvm::is_contained` use the `contains` member when available, instead of doing a linear scan. It seems like a bit of a foot gun to me to have 2 functions with almost identical names but vastly different performance characteristics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145895/new/

https://reviews.llvm.org/D145895



More information about the llvm-commits mailing list