[PATCH] D145930: [X86] Fix encoding for ATOMIC_LOGIC_OP

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 13 06:12:43 PDT 2023


RKSimon added a comment.

We should probably get this merged into 16.x - please can you raise a bug for tracking?



================
Comment at: llvm/lib/Target/X86/X86InstrCompiler.td:899
       SchedRW = [WriteBitTestSetRegRMW]  in {
-    def 16rm : Ii8<Opc8, MRMDestMem, (outs), (ins i16mem:$src1, GR16:$src2),
+    def 16rm : I<Opc8, MRMDestMem, (outs), (ins i16mem:$src1, GR16:$src2),
                   !strconcat(s, "{w}\t{$src2, $src1|$src1, $src2}"),
----------------
Copy + paste typo from the ATOMIC_LOGIC_OP above I suppose


================
Comment at: llvm/test/CodeGen/X86/atomic-rm-bit-test-64.ll:1663
+
+define i32 @atomic_global() nounwind {
+; CHECK-LABEL: atomic_global:
----------------
Please can you raise a bug and reference it here to speed up triage


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145930/new/

https://reviews.llvm.org/D145930



More information about the llvm-commits mailing list