[PATCH] D145766: [RISCV] Support Zfa fli instructions with vector splats.
Philip Reames via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 10 07:52:09 PST 2023
reames added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1550
+ return true;
+ if (VT == MVT::f64 && RISCVLoadFPImm::getLoadFP64Imm(Imm) != -1)
+ return true;
----------------
craig.topper wrote:
> reames wrote:
> > Hm, shouldn't this depend on having the D extension? (follow on)
> I'll add an assert. the caller in this file already checks D is enabled. The two calls in RISCVISelDAGToDAG.cpp only occur if f64 is a legal type which would require D if Zfa is enabled. Zfa is incompatible with Zdinx.
Ack
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145766/new/
https://reviews.llvm.org/D145766
More information about the llvm-commits
mailing list