[PATCH] D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag
    Martin Storsjö via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Mar  9 13:45:48 PST 2023
    
    
  
mstorsjo added inline comments.
================
Comment at: cmake/Modules/LLVMCheckCompilerLinkerFlag.cmake:3
 
-include(CheckCompilerFlag OPTIONAL)
+if (COMMAND check_compiler_linker_flag)
+  macro(llvm_check_compiler_linker_flag)
----------------
smeenai wrote:
> Is it intentional that you're checking for the `check_compiler_linker_flag` command here but using the `check_linker_flag` command below?
Oh, that does indeed look like a bug - good catch, sorry for not noticing!
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145716/new/
https://reviews.llvm.org/D145716
    
    
More information about the llvm-commits
mailing list