[PATCH] D145716: [CMake] Unify llvm_check_linker_flag and llvm_check_compiler_linker_flag

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 13:37:17 PST 2023


smeenai added inline comments.


================
Comment at: cmake/Modules/LLVMCheckCompilerLinkerFlag.cmake:3
 
-include(CheckCompilerFlag OPTIONAL)
+if (COMMAND check_compiler_linker_flag)
+  macro(llvm_check_compiler_linker_flag)
----------------
Is it intentional that you're checking for the `check_compiler_linker_flag` command here but using the `check_linker_flag` command below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145716/new/

https://reviews.llvm.org/D145716



More information about the llvm-commits mailing list