[PATCH] D144101: [test-suite] Increase the --filter-short threshold

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

This looks good to me. @fhahn ?



================
Comment at: utils/compare.py:342
+        except:
+            config.files.insert(0, config.filter_short)
+
----------------
SjoerdMeijer wrote:
> rengolin wrote:
> > what happens to `filter_short_threshold` on exception? Is it a stable behaviour?
> It defaults to `filter_short_threshold = 1.0` on line 329, so that should always be defined (but not always used).
> I think that makes it stable behaviour, but I am not a Python programmer, so might be missing something. Let me know what you think, I could do some more python research on try/except behaviour. 
Yeah, just worried the assignment won't occur before `float()` succeeds. If you pass "foobar" as the option and it's still `1.0`, than that's good enough. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144101/new/

https://reviews.llvm.org/D144101