[PATCH] D144101: [test-suite] Increase the --filter-short threshold

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 9 03:47:35 PST 2023


SjoerdMeijer added inline comments.


================
Comment at: utils/compare.py:342
+        except:
+            config.files.insert(0, config.filter_short)
+
----------------
rengolin wrote:
> what happens to `filter_short_threshold` on exception? Is it a stable behaviour?
It defaults to `filter_short_threshold = 1.0` on line 329, so that should always be defined (but not always used).
I think that makes it stable behaviour, but I am not a Python programmer, so might be missing something. Let me know what you think, I could do some more python research on try/except behaviour. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144101/new/

https://reviews.llvm.org/D144101



More information about the llvm-commits mailing list