[PATCH] D145572: [llvm][Uniformity] consistently handle uniform instructions

Wed Mar 8 23:14:35 PST 2023

ruiling added a comment.

In D145572#4180384 <https://reviews.llvm.org/D145572#4180384>, @sameerds wrote:

> In D145572#4180375 <https://reviews.llvm.org/D145572#4180375>, @ruiling wrote:
>
>> In D145572#4178109 <https://reviews.llvm.org/D145572#4178109>, @ronlieb wrote:
>>
>>> LGTM, as this resolves our downstream assertions seen in our CI
>>
>> Why would this fix an assertion? The description sounds like this is just an improvement. I think we need a reproducer for the assertion.
>
> Please see the comment regarding pushUsers().

Thanks for the point. Another question is does this affect a value defined in a divergent loop but used outside the loop case? For that situation, we still have to say the value is divergent.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145572/new/

https://reviews.llvm.org/D145572