[PATCH] D143646: [RISCV] Return false from shouldFormOverflowOp when type is i8 and i16

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:490
+                            bool MathUsed) const override {
+    if (Opcode != ISD::UADDO)
+      return false;
----------------
What if we did

```
if (VT == MVT::i8 || VT == MVT::i16)
  return false;

return TargetLowering::shouldFormOverflowOp(Opcode, VT, MathUsed);
```

That would match how you've described this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143646/new/

https://reviews.llvm.org/D143646