[PATCH] D143646: [RISCV] Return false from shouldFormOverflowOp when type is i8 and i16
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 8 09:09:56 PST 2023
craig.topper added a comment.
I'm not sure the tests are here are sufficient to motivate this change. They "noncanonical" having the 1 on the LHS of an add instead of the RHS. And they only test the +1 case. Does shouldFormOverflowOp only apply to +1?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143646/new/
https://reviews.llvm.org/D143646
More information about the llvm-commits
mailing list