[PATCH] D145472: [LV][AArch64] Resolve test failure due use of unordered container
Sushant Gokhale via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 8 01:51:18 PST 2023
sushgokh added a comment.
In D145472#4174810 <https://reviews.llvm.org/D145472#4174810>, @fhahn wrote:
> LGTM, thanks! The commit title could be a bit more descriptive by explicitly mentioning what the code change is, e.g. something like: `[LV] Use SetVector to collect invariants in calculateRegisterUsage.`
>
> Also, this is not AArch64 specific, so it would be good to drop the [AArch64] part.
Thanks @fhahn for the suggestion.
Regarding inclusion of AArch64 in title, I thought this was more about AArch64 test failure. But I was incorrect. Will keep this in mind that its more about the change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145472/new/
https://reviews.llvm.org/D145472
More information about the llvm-commits
mailing list