[PATCH] D145472: [LV][AArch64] Resolve test failure due use of unordered container

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 7 04:38:19 PST 2023


fhahn accepted this revision.
fhahn added a comment.

LGTM, thanks! The commit title could be a bit more descriptive by explicitly mentioning what the code change is, e.g. something like: `[LV] Use SetVector to collect invariants in calculateRegisterUsage.`

Also, this is not AArch64 specific, so it would be good to drop the [AArch64] part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145472/new/

https://reviews.llvm.org/D145472



More information about the llvm-commits mailing list