[PATCH] D145497: [AArch64] Allocate emergency spillslot when using fixed-length SVE.

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

Makes sense to me, one minor suggestion. I note that this introduces a few loads/stores to the stack for fixed length vectorization, but having it work correctly is the priority, those may be possible to remove later.



================
Comment at: llvm/test/CodeGen/AArch64/framelayout-sve-scavengingslot.mir:30
+---
+# This test verifies that an emergency scavenging slot is allocated when using fixed-length SVE
+name: RequiresScaveningSlotFixedLengthSVE
----------------
Since this test lacks check lines I presume it is meant to check only that llc exits successfully. Could you have checklines or a comment explaining what failure it is meant to catch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145497/new/

https://reviews.llvm.org/D145497