[PATCH] D144301: [dwarfdump][AMDGPU] Support EF_AMDGPU_MACH_NONE

Mon Mar 6 12:25:47 PST 2023

scott.linder marked 4 inline comments as done.
scott.linder added inline comments.

================
Comment at: llvm/test/tools/llvm-dwarfdump/AMDGPU/amdgcn-relocs.yaml:18-19
+
+# AMDGCN-UNKNOWN:   -: Error in creating MCRegInfo
+# AMDGCN-KNOWN-NOT: -: Error in creating MCRegInfo
+# AMDGCN: -:      file format elf64-amdgpu
----------------
jhenderson wrote:
> Up to you, but you could change these to be shared with the R600 cases too, since the message is the same.
> 
> That being said, why are you checking them?
AFAICT there are no other tests of llvm-dwarfdump with amdgpu code objects, so I wanted to capture as much of the current behavior as possible, including the warning about MCRegInfo that comes up when the object is an "Unknown" amdgpu arch. Ideally we would eventually have a more meaningful error message for the lay-user, or have some fallback behavior, but I didn't want to invest the time now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144301/new/

https://reviews.llvm.org/D144301