[PATCH] D144407: [NVPTX] Use proper parameter names in anonymous functions.

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Nice! I like that there's just one way to determine parameter name now.



================
Comment at: llvm/test/CodeGen/NVPTX/anonymous-fn-param.ll:11-13
+; CHECK:      .func (.param .b32 func_retval0) __unnamed_2(
+; CHECK-NEXT: .param .b32 __unnamed_2_param_0
+; CHECK:      ld.param.u32 {{%r[0-9]+}}, [__unnamed_2_param_0];
----------------
I'd move it down to the second function. When possible, checks should be placed close to the code that we're checking.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144407/new/

https://reviews.llvm.org/D144407