[PATCH] D142796: Flang semantic check support for tile and unroll OpenMP Directive.

[Leandro Lupori via Phabricator via llvm-commits]

luporl added inline comments.


================
Comment at: flang/test/Semantics/OpenMP/omp-do-tile.f90:2
+!RUN : % python % S /../ test_errors.py % s % flang -fopenmp 
+!OpenMP Version 5.1 !2.11.9.1 tile Cconstruct
+
----------------
Nit: it's better to put the `!2.11.9.1 tile Cconstruct` part on a new line.


================
Comment at: flang/test/Semantics/OpenMP/omp-do-tile.f90:3
+!OpenMP Version 5.1 !2.11.9.1 tile Cconstruct
+
+program omp_doTile 
----------------
abidmalikwaterloo wrote:
> The build is failing on the tests. Is this the right way to write the semantic tests for Flang? 
There are extra spaces in your RUN line. This should work:
`! RUN: %python %S/../test_errors.py %s %flang -fopenmp`


================
Comment at: flang/test/Semantics/OpenMP/omp-do-tile.f90:6-7
+	integer::j 
+	!ERROR: The value of the parameter in the size clause must 
+	!be greater than 0  
+        !$omp tile sizes(-1) 
----------------
`test_errors.py` will fail to match the error string here. It must be in a single line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142796/new/

https://reviews.llvm.org/D142796