[PATCH] D142796: Flang semantic check support for tile and unroll OpenMP Directive.

[Abid via Phabricator via llvm-commits]

abidmalikwaterloo added a comment.

Ping!



================
Comment at: flang/lib/Semantics/check-omp-structure.h:257
   void CheckMasterNesting(const parser::OpenMPBlockConstruct &x);
+  void CheckTileConstruct(const parser::OpenMPLoopConstruct &x);
+  void CheckUnrollConstruct(const parser::OpenMPLoopConstruct &x);
----------------
Are there any more checks needed at this stage? Besides checking integer expression, the length of the list should be equal to the depth of the nested loops


================
Comment at: flang/test/Semantics/OpenMP/omp-do-tile.f90:3
+!OpenMP Version 5.1 !2.11.9.1 tile Cconstruct
+
+program omp_doTile 
----------------
The build is failing on the tests. Is this the right way to write the semantic tests for Flang? 


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:72
   let clangClass = "OMPSizesClause"; 
   let flangClass = "ScalarIntExpr";
   }
----------------
We need  a list of integers to take care of the nested loops
```
!$omp tile sizes(size-list) 
   loop-nest 
[!$omp end tile]
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142796/new/

https://reviews.llvm.org/D142796