[PATCH] D144783: [ELF] Move getSectionAndRelocations to ELF.cpp from ELFDumper.cpp

Aiden Grossman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 3 15:28:24 PST 2023


aidengrossman added a comment.

Marked some inline comments as done. I've also gotten rid of the `getSectionAndRelocations` wrapper inside of `ELFDumper.cpp` because it was somewhat confusing in regards to the naming and also is less compatible with how we're now treating error handling. Again, this now does change some behavior as we're now failing earlier, so maybe this should be noted somewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144783/new/

https://reviews.llvm.org/D144783



More information about the llvm-commits mailing list