[PATCH] D144783: [ELF] Move getSectionAndRelocations to ELF.cpp from ELFDumper.cpp

[Aiden Grossman via Phabricator via llvm-commits]

aidengrossman updated this revision to Diff 502275.
aidengrossman marked 10 inline comments as done.
aidengrossman added a comment.

Address some reviewer feedback, particularly moving from return by parameter to
return by value, returning an `Expected<...>` that will contain errors if there
is a failure. This does produce a slight functional change in
`getSectionAndRelocations()` because instead of returning a partially
incomplete map if there are any errors, we are now not returning any map and
just returning the errors. This doesn't break any test cases and doesn't seem
like a bad change of behavior to me, but it is something to note.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144783/new/

https://reviews.llvm.org/D144783

Files:
  llvm/include/llvm/Object/ELF.h
  llvm/lib/Object/ELF.cpp
  llvm/tools/llvm-readobj/ELFDumper.cpp
  llvm/unittests/Object/ELFObjectFileTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144783.502275.patch
Type: text/x-patch
Size: 9931 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230303/0be50d91/attachment-0001.bin>