[PATCH] D144221: [amdgpu][nfc] Replace ad hoc LDS frame recalculation with absolute_symbol MD

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.cpp:103
+AMDGPUMachineFunction::parseSingleOperandMetadata(MDNode *MD) {
+  if (MD && MD->getNumOperands() == 1) {
+    if (ConstantInt *KnownSize =
----------------
arsenm wrote:
> Early return (or just move the null check to the caller). 
> 
> The verifier should really be enforcing the operand count so every user doesn't need to check that it's 1. Should add the verifier check and drop the check
Also there is already GlobalValue::getAbsoluteSymbolRange()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144221/new/

https://reviews.llvm.org/D144221