[PATCH] D144221: [amdgpu][nfc] Replace ad hoc LDS frame recalculation with absolute_symbol MD

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:668
+    GV->setMetadata(LLVMContext::MD_absolute_symbol,
+                    MDNode::get(Ctx, ConstantAsMetadata::get(
+                                         ConstantInt::get(Type, Address))));
----------------
Going based on the langref, this is incorrect usage of absolute_symbol. It seems to expect 2 operands, indicating an absolute range. I assume you can specify specific address, specific address + 1 for a fixed address. Again demonstrates that the verifier really should check this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144221/new/

https://reviews.llvm.org/D144221