[PATCH] D145001: [X86] Add additional tests for folding `(select (setgt X, -1), C, C+1)`; NFC

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - cheers



================
Comment at: llvm/test/CodeGen/X86/select-constant-xor.ll:47
 
 define i32 @selecti64i32(i64 %a) {
 ; X86-LABEL: selecti64i32:
----------------
found it!


================
Comment at: llvm/test/CodeGen/X86/select-constant-xor.ll:68
 
 define i64 @selecti32i64(i32 %a) {
 ; X86-LABEL: selecti32i64:
----------------
found it!


================
Comment at: llvm/test/CodeGen/X86/select-constant-xor.ll:258
+
+; we already have a test for the i64 case at `selecti64i32`.
+define i32 @selecti16i32_offby1(i16 %a) {
----------------
Cheers - instead of temporarily altering your patch like this you can just add a comment in phab to any line in the file 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145001/new/

https://reviews.llvm.org/D145001